🅱️ode 🅱️ritique

The constant death march toward modernization is a dangerous effort to optimize the future at the cost of our past. I propose a countermethod, instead adopting the styles of assembly; you can see there is a kind of beautiful clarity in the bones of the machine, in full view as the onion skins are pullled away.

@_ENTRY
    MOV SP$,@HELLO
    GOSUB @PUTSTR
    PUTCHR 10      'LINE ENDING
    END

@PUTSTR
    POPB A
    IF EQU(A,0) THEN RETURN
    PUTCHR A
    GOTO @PUTSTR

@HELLO DATA "Hello, world!",0



DEF MOV _,L
RESTORE L
READ SP$
SP$=SP$+CHR$(0)
END
DEF POPB _
A=ASC(SHIFT(SP$))
END
DEF EQU(A,B)
RETURN A==B
END
DEF PUTCHR V
PRINT CHR$(V);
END

not familiar with _ as a parameter name or how its treated at a compile time.. but shouldnt some of the lines be

READ _
_=_ + CHR$(0)
...
_=ASC(SHIFT(SP$))

POPB dedicated to popping from sp$...like stack pointer string pointer.. in that case mov doesnt need SP$ as a parameter. Wouldnt thT be more like loadsp or some flavor.

it's just a legal identifier that happens to look funny calm down

VAR _ = 10
PRINT _ '10

DEF PLEN V
 PRINT LEN(V)
END

PLEN "ABC" '3
PLEN 123   'runtime type mismatch

please review my code why it dont work exec "prg1:lib" main = IO() signal(main, print("hello")) run(main, 9696195221+λ)

DEF FAC(V1)
 VAR RET
 FOR I=V1 TO 1 STEP -1
  RET=RET*I
 NEXT
 RETURN RET
END

CLS
?"Loading sprites"
WAIT 480

Hey try to fix this one It's supposed to be a factorial function but it always returns 0

DEF FACK(IN)
 IF IN > 2 THEN
  RETURN IN * FACK(IN-1)
 ELSEIF IN < -1 THEN
  RETURN IN * FACK(IN+1)
 ELSE
  RETURN IN
 ENDIF
END

Hey try to fix this one:

DEF FAC(V1)
 VAR RET
 FOR I=V1 TO 1 STEP -1
  RET=RET*I
 NEXT
 RETURN RET
END

DEF FAC(V1)
  VAR RET=MAX(V1,1)
  FOR I=V1-1 TO 2 STEP -1
    RET=RET*I
  NEXT
  RETURN RET
END

@SEQ_FACT
DATA 1,1,2,6,24,120,720,5040,40320,362880,3628800,479001600
DIM FACT_TBL[0]
COPY FACT_TBL,@SEQ_FACT

DEF FASTFACT(N)
  IF N>=0 && N<12 THEN RETURN FACT_TBL[N]
  RETURN 0
END

DEF FACT N OUT F
 F=479001600
 FOR N=N+1 TO 12
  F=F DIV N
 NEXT
END

DEF FAC(N)
 IF N>1 THEN
  RETURN (N*FAC(N-1))*(N<13)+(-1*(N>12))
 ELSEIF N>0 THEN
  RETURN 1
 ENDIF
RETURN 0
END

COMMON DEF ISDIGIT (A$)
  FOR I = 0 TO LEN(A$) - 1
    IF ASC(A$[I]) >= 48 AND ASC(A$[I]) <= 57 THEN
      RETURN TRUE
    ELSE
      RETURN FALSE
    ENDIF
  NEXT I
END

COMMON DEF ISDIGIT(C$)
  RETURN C$>="0" && C$<":"
  ': in case C$ really is string
END

COMMON DEF ISLETTER (A$)
  FOR I = 0 TO LEN(A$) - 1
    IF ASC(A$[I]) >= 65 AND ASC(A$[I]) <= 90 THEN
      RETURN TRUE
    ELSEIF ASC(A$[I]) >= 97 AND ASC(A$[I]) <= 122 THEN
      RETURN TRUE
    ELSE
      RETURN FALSE
    ENDIF
  NEXT I
END

COMMON DEF ISLETTER(C$)
  RETURN (C$>="A"&&C$<"[") || (C$>="a"&&C$<"{")
END

COMMON DEF UPPER (A$)
  T$ = ""
  FOR I = 0 TO LEN(A$) - 1
    IF ASC(A$[I]) >= 97 AND ASC(A$[I]) <= 122 THEN
      N = ASC(A$[I]): N = N - 32
      T$ = T$ + CHR$(N)
    ELSE
      T$ = T$ + A$[I]
    ENDIF
  NEXT I
  RETURN T$
END

COMMON DEF UPPER(A$)
  VAR T$=A$*1 'clone A$
  VAR N
  FOR I=LEN(A$)-1 TO 0 STEP -1 'iterate backwards
    N=ASC(T$[I])
    IF N>=97 && N<=122 THEN T$[I]=CHR$(N-32)
  NEXT
  RETURN T$
END

DEF UPPER(S$)
 RETURN DIALOG(S$,"")
END

This is the worst code I've ever wrote (view it with code wrap enabled) [QRF4D3V3] (key because I dnot have 3.6.0)

This is the worst code I've ever wrote (view it with code wrap enabled) [QRF4D3V3] (key because I dnot have 3.6.0)

You should use ACLS instead of CLS, just in case

AAA why me game dnot wor?k int PLAUYER% WHILE 1 { console.log(FORMAT$("%d",math.random(10))); SPVAR PLAUYER%,1 (SETQ A (+1 A)) puts A unless A%2 WEND

SNIP

Uhh you kinda went WHILE 1{ WEND instead of WHILE 1{ } or WHILE 1 WEND I'm only judging this off of what I've seen people do in other languages, I don't actually know how the {} thing works.